Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release playwrighttesting microsoft.playwright testing.auth manager 2024 12 01 #31855

Merged
merged 34 commits into from
Jan 7, 2025
Merged

Release playwrighttesting microsoft.playwright testing.auth manager 2024 12 01 #31855

merged 34 commits into from
Jan 7, 2025

Conversation

mjmadhu
Copy link
Member

@mjmadhu mjmadhu commented Dec 12, 2024 •
edited
Loading

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@mjmadhu
Copy files from preview/2023-10-01-preview
a26928d 
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
@mjmadhu
Update version to stable/2024-12-01
36c6afd 
Updated the API version from preview/2023-10-01-preview to stable/2024-12-01.
@mjmadhu
Added tag for 2024-12-01 in readme file
52a1a37
@mjmadhu
Added stable api-version for data-plane auth manager apis
9cc3283
@mjmadhu
Rectified a typo
1db7b13
@mjmadhu mjmadhu requested a review from a team as a code owner December 12, 2024 09:26
@mjmadhu mjmadhu requested review from allenjzhang and mario-guerra and removed request for a team December 12, 2024 09:26
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 12, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for JavaScript (label: BreakingChange-JavaScript-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Dec 12, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/playwrighttesting/armplaywrighttesting There is no API change compared with the previous version
Java azure-developer-microsoftplaywrighttesting https://apiview.dev/Assemblies/Review/5a14b0d42e2547158388bd3df7bbdfc6?revisionId=986c5e49ee63444d9210cd3730d7e6a7
Java azure-resourcemanager-playwrighttesting https://apiview.dev/Assemblies/Review/1bd459ec74cb4a53a4d19cdb7e9db406?revisionId=88bda2c24c6e411ea0b8b2473a17c3a6
JavaScript @azure/arm-playwrighttesting https://apiview.dev/Assemblies/Review/3a5ef77675cd496b8ea7476458ea8d4b?revisionId=1072258d5c3042c29eb72d0e79d79a2f
Python azure-developer-microsoftplaywrighttesting https://apiview.dev/Assemblies/Review/e237446c5ce54ef4b6dd919cd972c074?revisionId=7cc3b6b9afb840f6ab2fd0b50dd177dc
Python azure-mgmt-playwrighttesting https://apiview.dev/Assemblies/Review/2213c5dc9a8f4408a2b0c3b87606308c?revisionId=d07efa93a8fd461f97135d1651624f78
TypeSpec PlaywrightTesting.AuthManager https://apiview.dev/Assemblies/Review/a5fa01f7e5564dd0b9a5dfc2c97935ef?revisionId=a7b47f7a37704d29b522339aadf257d6
TypeSpec PlaywrightTesting.Management https://apiview.dev/Assemblies/Review/8d7e4b8460bd4874b59430d6790390d8?revisionId=11850451242f40cdac0b76599775b551

@mjmadhu mjmadhu enabled auto-merge (squash) December 12, 2024 09:31
This was referenced Dec 12, 2024
Draft
Draft
Draft
Draft
@mjmadhu mjmadhu changed the base branch from release-playwrighttesting-Microsoft.PlaywrightTesting.AuthManager-2024-12-01-devv to release-playwrighttesting-Microsoft.PlaywrightTesting.AuthManager-2024-12-01 December 12, 2024 10:21
@mjmadhu mjmadhu changed the title Rectified a typo Added stable api-version for data-plane auth manager apis Dec 12, 2024
@azure-sdk azure-sdk mentioned this pull request Dec 12, 2024
Draft
This was referenced Dec 12, 2024
Draft
Draft
@mikekistler mikekistler linked an issue Dec 21, 2024 that may be closed by this pull request
[Playwright-DevDiv-Service - Playwright] API Review #31794
Closed
@azure-sdk azure-sdk mentioned this pull request Dec 27, 2024
Draft
@weidongxu-microsoft weidongxu-microsoft added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Dec 27, 2024
@mjmadhu
Copy link
Member Author

mjmadhu commented Jan 2, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@vvs11
Copy link
Member

vvs11 commented Jan 6, 2025

PublishToCustomers

@mjmadhu mjmadhu added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 7, 2025
@mjmadhu mjmadhu merged commit 74157f1 into main Jan 7, 2025
25 of 30 checks passed
@mjmadhu mjmadhu deleted the dev-playwrighttesting-Microsoft.PlaywrightTesting.AuthManager-2024-12-01-devv branch January 7, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekistler mikekistler mikekistler approved these changes

@prakash-amit prakash-amit prakash-amit approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@puagarwa puagarwa puagarwa approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner automatically assigned from Azure/api-stewardship-board

@mario-guerra mario-guerra Awaiting requested review from mario-guerra mario-guerra is a code owner automatically assigned from Azure/api-stewardship-board

Assignees
No one assigned
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. Approved-LintDiff Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-JavaScript-Sdk BreakingChange-Python-Sdk-Approved data-plane new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS SuppressionReviewRequired TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Playwright-DevDiv-Service - Playwright] API Review
10 participants
@mjmadhu @azure-sdk @vvs11 @puagarwa @weidongxu-microsoft @prakash-amit @mikekistler @krisnaray @AzureRestAPISpecReview @msyyc